Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference assemblies #627

Closed
wants to merge 4 commits into from
Closed

Add reference assemblies #627

wants to merge 4 commits into from

Conversation

billwert
Copy link
Member

No description provided.

@billwert billwert mentioned this pull request Jul 11, 2019
Open
@billwert
Copy link
Member Author

fails due to dotnet/BenchmarkDotNet#1197. I have another idea to unblock it though..

@adamsitnik
Copy link
Member

I saw dotnet/BenchmarkDotNet#1197 and I need to wrap my head around it. Tomorrow I am OOF so I won't have a solution this week.

michellemcdaniel
michellemcdaniel approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@michellemcdaniel michellemcdaniel self-requested a review July 11, 2019 22:15
@billwert
Copy link
Member Author

This is going to have to wait until we get a fix from BDN. The Directory.Build.props approach is blocked specifically.

@billwert billwert closed this Jul 14, 2019
@billwert billwert deleted the add-reference-assemblies branch October 29, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellemcdaniel michellemcdaniel Awaiting requested review from michellemcdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billwert @adamsitnik @michellemcdaniel